aiguofer commented on code in PR #39356:
URL: https://github.com/apache/arrow/pull/39356#discussion_r1439153852
##########
java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/consumer/CompositeJdbcConsumer.java:
##########
@@ -43,7 +46,18 @@ public CompositeJdbcConsumer(JdbcConsumer[] consumers) {
@Override
public void consume(ResultSet rs) throws SQLException, IOException {
for (int i = 0; i < consumers.length; i++) {
- consumers[i].consume(rs);
+ try {
+ consumers[i].consume(rs);
Review Comment:
What do you mean?
If you mean that every consumer that extends BaseConsumer should implement
its own `try/catch` to throw the `JdbcConsumerException` within its `consume`
method then I think it's doable, but it would require more changes and require
more effort when implementing a custom consumer (users would need to ensure
they add the try/catch logic as well). Handling it here seems easier to both
implement and use since custom consumers can just extend `BaseConsumer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
