aiguofer commented on PR #39356:
URL: https://github.com/apache/arrow/pull/39356#issuecomment-1879072207

   Sorry all, I'm just getting back from break. Hmm, I think it might be better 
to add a `throws` instead. The exceptions are not always a `SQLException`. For 
example, in our case what prompted this PR was this redacted stack trace:
   
   ```
   java.lang.RuntimeException: Error occurred while getting next schema root.
        at 
org.apache.arrow.adapter.jdbc.ArrowVectorIterator.next(ArrowVectorIterator.java:181)
           ...
   Caused by: java.lang.RuntimeException: Error occurred while consuming data.
        at 
org.apache.arrow.adapter.jdbc.ArrowVectorIterator.consumeData(ArrowVectorIterator.java:117)
        at 
org.apache.arrow.adapter.jdbc.ArrowVectorIterator.load(ArrowVectorIterator.java:159)
        at 
org.apache.arrow.adapter.jdbc.ArrowVectorIterator.next(ArrowVectorIterator.java:177)
        ... 10 common frames omitted
   Caused by: java.lang.UnsupportedOperationException: Decimal size greater 
than 16 bytes: 17
        at 
org.apache.arrow.vector.util.DecimalUtility.writeByteArrayToArrowBufHelper(DecimalUtility.java:175)
        at 
org.apache.arrow.vector.util.DecimalUtility.writeBigDecimalToArrowBuf(DecimalUtility.java:136)
        at org.apache.arrow.vector.DecimalVector.set(DecimalVector.java:365)
        at 
org.apache.arrow.adapter.jdbc.consumer.DecimalConsumer.set(DecimalConsumer.java:79)
        at 
org.apache.arrow.adapter.jdbc.consumer.DecimalConsumer$NullableDecimalConsumer.consume(DecimalConsumer.java:101)
        at 
org.apache.arrow.adapter.jdbc.consumer.CompositeJdbcConsumer.consume(CompositeJdbcConsumer.java:46)
        at 
org.apache.arrow.adapter.jdbc.ArrowVectorIterator.consumeData(ArrowVectorIterator.java:106)
        ... 12 common frames omitted
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to