peter-toth commented on PR #8664: URL: https://github.com/apache/arrow-datafusion/pull/8664#issuecomment-1874089036
@ozankabak, @berkaysynnada, I've refactored `OrderPreservationContext` using `TreeNode.transform_with_payload()` in https://github.com/apache/arrow-datafusion/pull/8664/commits/269d8ba9695085a0e4c65ec713cd49094fc3a0cf commit of this PR. IMO the new algorighm not just removes `OrderPreservationContext`, but also makes the algorighm simpler and more effective. I was able to eliminate the inner top-down transformation of `get_updated_plan()` that was kicked off at `SortExec` nodes during the bottom-up transformation of `transform_up()`. The new algorighm, that uses `TreeNode.transform_with_payload()`, does only one traversal. Please find the details here: https://github.com/apache/arrow-datafusion/pull/8664/commits/269d8ba9695085a0e4c65ec713cd49094fc3a0cf#diff-7894863f285ed3ad976c94603d639b99955d4a581e5eaee5f5946960fcbc21e1R52-R67 Please let me know if you still have concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
