ozankabak commented on PR #8664: URL: https://github.com/apache/arrow-datafusion/pull/8664#issuecomment-1879821075
Two pieces of news from our side: 1. I think I figured out a possible way to simplify the overall `TreeNode`-related code and reduce code duplication significantly. I plan to post a PR on Monday. 2. I think the integrated up/down idea may indeed be useful. I will try to figure out the trade-off between using the existing `Visitor`/`pre_visit`/`post_visit` mechanism and having a new kind of `transform` function. In any case, 2 (which is the main concern of this PR) will benefit from 1 so I will go step by step finish off 1 first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
