mapleFU commented on code in PR #39393:
URL: https://github.com/apache/arrow/pull/39393#discussion_r1440385335
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -1370,6 +1402,54 @@ class TypedRecordReader : public
TypedColumnReaderImpl<DType>,
return bytes_for_values;
}
+ // Two parts different from original HasNextInternal:
Review Comment:
> First of all, it is strange to execute `SkipRecords` on the basis of hit
lines.
I think if Parquet user is using a dense read with selection vector, or
doing something like incremental filtering, it's possible to do this. Since
`SkipRecords` is exported, and it's used when skipping the records within page,
I think the interface is a bit weird🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
