troychiu commented on PR #5281: URL: https://github.com/apache/arrow-rs/pull/5281#issuecomment-1878140627
Hi @tustvold, I am relatively new to Rust, and I am wondering if you could give me some suggestions on this PR. I have implemented the functionalities, but I ran into two issues. 1. Error handling: For some errors, I added new values to Error enum. I am wondering if it's correct way. Also, I am wondering if I should do the same thing for the multipart writer. 2. Downloading is slow: I compared this Rust implementation to my Python implementation and found the Rust implementation here is relatively slow. Could you help me check if there is any obvious flaw in my implementation? Thank you for your time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
