tustvold commented on code in PR #5281:
URL: https://github.com/apache/arrow-rs/pull/5281#discussion_r1442761392
##########
object_store/src/local.rs:
##########
@@ -1082,6 +1097,58 @@ fn convert_walkdir_result(
}
}
+
+/// Download a remote object to a local [`File`]
+pub async fn upload(store: &dyn ObjectStore, location: &Path, opts:
PutOptions, file: &mut std::fs::File) -> Result<()> {
Review Comment:
So the difficulty with AsyncRead / AsyncWrite is there isn't actually an
efficient way to implement them, tokio::fs::File calls `spawn_blocking` for
every call, which is hopelessly inefficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
