andrew0 commented on code in PR #39475:
URL: https://github.com/apache/arrow/pull/39475#discussion_r1443344349
##########
js/gulp/package-task.js:
##########
@@ -54,18 +57,17 @@ const createMainPackageJson = (target, format) => (orig) =>
({
node: {
import: `./${mainExport}.node.mjs`,
require: `./${mainExport}.node.js`,
+ types: `./${mainExport}.node.d.ts`,
Review Comment:
The TypeScript docs say that the `types` property should come first:
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing.
Not 100% sure the reasoning since the docs don't really explain it but I think
it can mess with the resolution priorities somehow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
