andrew0 commented on PR #39475: URL: https://github.com/apache/arrow/pull/39475#issuecomment-1879251883
I ran `yarn build && npx @arethetypeswrong/cli --pack targets/apache-arrow`, and it gives these errors: <img width="495" alt="image" src="https://github.com/apache/arrow/assets/739172/d642f026-a2a8-4886-9a20-9c7281ae6f95";> after changing the `types` to come first: <img width="466" alt="image" src="https://github.com/apache/arrow/assets/739172/7a8b666e-5b21-4f08-b50f-340769775258";> The [masquerading as CJS](https://github.com/arethetypeswrong/arethetypeswrong.github.io/blob/main/docs/problems/FalseCJS.md) error will make it so in ESM mode, which I believe makes it so TypeScript will let you do `import arrow from 'apache-arrow'`, which would be a runtime error since there's no default export, so it really should be `import * as arrow from 'apache-arrow'`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
