jayzhan211 commented on code in PR #8781:
URL: https://github.com/apache/arrow-datafusion/pull/8781#discussion_r1444617711
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -529,7 +529,7 @@ fn general_except<OffsetSize: OffsetSizeTrait>(
pub fn array_except(args: &[ArrayRef]) -> Result<ArrayRef> {
if args.len() != 2 {
- return internal_err!("array_except needs two arguments");
+ return exec_err!("array_except needs two arguments");
Review Comment:
When to use internal, when to use exec_err?
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -529,7 +529,7 @@ fn general_except<OffsetSize: OffsetSizeTrait>(
pub fn array_except(args: &[ArrayRef]) -> Result<ArrayRef> {
if args.len() != 2 {
- return internal_err!("array_except needs two arguments");
+ return exec_err!("array_except needs two arguments");
Review Comment:
When to use internal_err, when to use exec_err?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
