crepererum commented on code in PR #8781:
URL: https://github.com/apache/arrow-datafusion/pull/8781#discussion_r1444685792
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -529,7 +529,7 @@ fn general_except<OffsetSize: OffsetSizeTrait>(
pub fn array_except(args: &[ArrayRef]) -> Result<ArrayRef> {
if args.len() != 2 {
- return internal_err!("array_except needs two arguments");
+ return exec_err!("array_except needs two arguments");
Review Comment:
`internal_err`: something that wasn't expected/anticipated by the
implementation and that is most likely a bug (the error message even encourages
users to open a bug report). I user should not be able to trigger this under
normal circumstances. Note that I/O errors (or any error that happens due to
external systems) do NOT fall under this category (there's an external error
variant for that)
`exec_err`: a processing error that happens during execution, e.g. the user
passed malformed arguments to a SQL method, opened a CSV file that is broken,
tried to divide an integer by zero. these errors shouldn't happen for a "good"
query + "good" data, but since both the query and the data can easily be broken
or misaligned, these are common occurrences in ETL systems / databases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
