jorisvandenbossche commented on code in PR #39360:
URL: https://github.com/apache/arrow/pull/39360#discussion_r1444775220
##########
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc:
##########
@@ -1503,14 +1503,13 @@ struct ISOCalendar {
std::unique_ptr<ArrayBuilder> array_builder;
RETURN_NOT_OK(MakeBuilder(ctx->memory_pool(), IsoCalendarType(),
&array_builder));
StructBuilder* struct_builder =
checked_cast<StructBuilder*>(array_builder.get());
- RETURN_NOT_OK(struct_builder->Reserve(in.length));
Review Comment:
Should this be kept? (eg `struct_builder->AppendNull()` is used, which might
also set the top-level bitmap?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
