jorisvandenbossche commented on code in PR #39360:
URL: https://github.com/apache/arrow/pull/39360#discussion_r1444781113
##########
python/pyarrow/tests/test_compute.py:
##########
@@ -2223,6 +2223,29 @@ def _check_datetime_components(timestamps,
timezone=None):
first_week_is_fully_in_year=False)
assert pc.week(tsa, options=week_options).equals(pa.array(iso_week))
+ # Test for iso_calendar regression
Review Comment:
Can you move this to a separate test? The `_check_datetime_components`
function is already quite long, and the below also doesn't actually use
`timestamps`, so it's a bit strange to put it here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
