joellubi commented on code in PR #39491:
URL: https://github.com/apache/arrow/pull/39491#discussion_r1445482743
##########
cpp/src/parquet/arrow/schema_internal.cc:
##########
@@ -90,7 +90,7 @@ Result<std::shared_ptr<ArrowType>> MakeArrowTime64(const
LogicalType& logical_ty
Result<std::shared_ptr<ArrowType>> MakeArrowTimestamp(const LogicalType&
logical_type) {
const auto& timestamp = checked_cast<const
TimestampLogicalType&>(logical_type);
const bool utc_normalized =
- timestamp.is_from_converted_type() ? false :
timestamp.is_adjusted_to_utc();
+ timestamp.is_from_converted_type() ? true :
timestamp.is_adjusted_to_utc();
Review Comment:
I think the following would be equivalent to the updated ternary expression:
```cpp
const bool utc_normalized = timestamp.is_from_converted_type() ||
timestamp.is_adjusted_to_utc();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
