wgtmac commented on code in PR #39491:
URL: https://github.com/apache/arrow/pull/39491#discussion_r1445571136
##########
cpp/src/parquet/arrow/schema_internal.cc:
##########
@@ -90,7 +90,7 @@ Result<std::shared_ptr<ArrowType>> MakeArrowTime64(const
LogicalType& logical_ty
Result<std::shared_ptr<ArrowType>> MakeArrowTimestamp(const LogicalType&
logical_type) {
const auto& timestamp = checked_cast<const
TimestampLogicalType&>(logical_type);
const bool utc_normalized =
- timestamp.is_from_converted_type() ? false :
timestamp.is_adjusted_to_utc();
+ timestamp.is_from_converted_type() ? true :
timestamp.is_adjusted_to_utc();
Review Comment:
> Here, every caller except here is set to true. See:
https://github.com/apache/arrow/blob/main/cpp/src/parquet/schema.cc#L443
>
> By the way, I didn't find Int96 in the doc, would Int96 should having
`is_adjusted_to_utc = true` ? (Rust impl set it false)
IMO, INT96 is a physical type and orthogonal to logical/converted type.
##########
cpp/src/parquet/types.cc:
##########
@@ -345,15 +345,19 @@ std::shared_ptr<const LogicalType>
LogicalType::FromConvertedType(
case ConvertedType::DATE:
return DateLogicalType::Make();
case ConvertedType::TIME_MILLIS:
Review Comment:
It would be good to add the parity for timestamp type as well:
https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#deprecated-timestamp-convertedtype,
just in case people are looking for timestamp type only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
