mustafasrepo commented on code in PR #8842:
URL: https://github.com/apache/arrow-datafusion/pull/8842#discussion_r1451994413
##########
datafusion/expr/src/window_frame.rs:
##########
@@ -30,21 +30,24 @@ use sqlparser::ast;
use sqlparser::parser::ParserError::ParserError;
use std::convert::{From, TryFrom};
use std::fmt;
+use std::fmt::Formatter;
use std::hash::Hash;
/// The frame-spec determines which output rows are read by an aggregate
window function.
///
/// The ending frame boundary can be omitted (if the BETWEEN and AND keywords
that surround the
/// starting frame boundary are also omitted), in which case the ending frame
boundary defaults to
/// CURRENT ROW.
-#[derive(Debug, Clone, PartialEq, Eq, Hash)]
+#[derive(Clone, PartialEq, Eq, Hash)]
pub struct WindowFrame {
/// A frame type - either ROWS, RANGE or GROUPS
pub units: WindowFrameUnits,
/// A starting frame boundary
pub start_bound: WindowFrameBound,
/// An ending frame boundary
pub end_bound: WindowFrameBound,
+ /// Flag indicates whether window frame is causal.
Review Comment:
Added a docstring to `is_frame_causal` and link it here for explanation.
Thanks for pointing this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
