mustafasrepo commented on PR #8842:
URL:
https://github.com/apache/arrow-datafusion/pull/8842#issuecomment-1891533997
> Thank you for this PR @mustafasrepo -- I feel I lack the context to review
it properly, maybe could you explain the usecase (ideally in doc comments
somewhere) with an example or two?
>
> Also, the PR description talks about emitting batches earlier, but I
didn't see any test coverage of that. Was that intended?
> Add new test
> Thank you for this PR @mustafasrepo -- I feel I lack the context to review
it properly, maybe could you explain the usecase (ideally in doc comments
somewhere) with an example or two?
>
> Also, the PR description talks about emitting batches earlier, but I
didn't see any test coverage of that. Was that intended?
At first, I thought it would be hard to exactly test this behaviour.
However, after some thinking I found out it wouldn't be that hard. I have added
a test for this case in
[commit](https://github.com/apache/arrow-datafusion/pull/8842/commits/4723dc687699787ebbeb950173c785ab7f39110b)
Thanks for pointing this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
