ShaiviAgarwal2 commented on code in PR #39595:
URL: https://github.com/apache/arrow/pull/39595#discussion_r1451997620
##########
matlab/CMakeLists.txt:
##########
@@ -131,6 +131,14 @@ if(NOT Arrow_FOUND)
build_arrow()
endif()
+# Identify MATLAB build mode (Debug or Release)
+if(WIN32)
+ execute_process(COMMAND dumpbin /dependents ${Matlab_MAIN_PROGRAM}
OUTPUT_VARIABLE DEPENDENTS)
Review Comment:
> @kevingurney Is there any MATLAB main program that is built in Debug mode
on Windows?
>
> If all MATLAB main programs are built in Release mode on Windows, we don't
need to check this.
>
> We just need to check our build mode instead:
>
> ```cmake
> if(WIN32)
> string(TOUPPER "${CMAKE_BUILD_TYPE}" CMAKE_BUILD_TYPE_UPPER)
> if(CMAKE_BUILD_TYPE_UPPER STREQUAL DEBUG)
> message(FATAL_ERROR "...")
> endif()
> endif()
> ```
@kou Should I start working upon this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
