kevingurney commented on code in PR #39595:
URL: https://github.com/apache/arrow/pull/39595#discussion_r1453680689


##########
matlab/CMakeLists.txt:
##########
@@ -131,6 +131,14 @@ if(NOT Arrow_FOUND)
   build_arrow()
 endif()
 
+# Identify MATLAB build mode (Debug or Release)
+if(WIN32)
+  execute_process(COMMAND dumpbin /dependents ${Matlab_MAIN_PROGRAM} 
OUTPUT_VARIABLE DEPENDENTS)

Review Comment:
   @kou and @ShaiviAgarwal2 - sorry for delay!
   
   To answer your question: all publicly released versions of MATLAB are built 
in release mode (i.e. linked against a release version of the MSVC Runtime 
Libraries).
   
   I agree with @kou's suggestion that addressing this issue should not require 
looking at the dependencies of `Matlab_MAIN_PROGRAM`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to