kou commented on code in PR #39586:
URL: https://github.com/apache/arrow/pull/39586#discussion_r1452015754
##########
matlab/test/arrow/type/tDate32Type.m:
##########
@@ -15,7 +15,9 @@
% implied. See the License for the specific language governing
% permissions and limitations under the License.
-classdef tDate32Type < hFixedWidthType
+
+
Review Comment:
Could you revert this needless newline change?
```suggestion
```
##########
matlab/test/arrow/type/tDate64Type.m:
##########
@@ -15,7 +15,9 @@
% implied. See the License for the specific language governing
% permissions and limitations under the License.
-classdef tDate64Type < hFixedWidthType
+
+
Review Comment:
```suggestion
```
##########
matlab/test/arrow/type/tDate32Type.m:
##########
@@ -88,7 +97,6 @@ function IsEqualFalse(testCase)
typeArray2 = [date32Type date32Type]';
testCase.verifyFalse(isequal(typeArray1, typeArray2));
end
-
end
-
end
+
Review Comment:
```suggestion
```
##########
matlab/test/arrow/type/tDateTypeTest.m:
##########
@@ -0,0 +1,92 @@
+% Shared superclass for DateType-related tests
+
+
+% Licensed to the Apache Software Foundation (ASF) under one or more
+% contributor license agreements. See the NOTICE file distributed with
+% this work for additional information regarding copyright ownership.
+% The ASF licenses this file to you under the Apache License, Version
+% 2.0 (the "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS,
+% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+% implied. See the License for the specific language governing
+% permissions and limitations under the License.
+
+classdef hDateTypeTest < hFixedWidthType
Review Comment:
Can we remove `Test` suffix from class name and file name (`tDateType.m`)?
It seems that others don't have it.
```suggestion
classdef hDateType < hFixedWidthType
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
