kou commented on code in PR #39221:
URL: https://github.com/apache/arrow/pull/39221#discussion_r1452346519
##########
ci/scripts/java_jni_build.sh:
##########
@@ -56,7 +68,7 @@ cmake \
-DBUILD_TESTING=${ARROW_JAVA_BUILD_TESTS} \
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
-DCMAKE_PREFIX_PATH=${arrow_install_dir} \
- -DCMAKE_INSTALL_LIBDIR=lib \
+ -DCMAKE_ARCH_DIR=${normalized_arch} \
Review Comment:
Please don't use `CMAKE_` prefix for our variable. Please use
`ARROW_JAVA_JNI_` prefix like other our variables such as
`ARROW_JAVA_JNI_ENABLE_DEFAULT` instead.
BTW, why do we need to install to sub directory such as
`lib/arrow_cdata_jni/${arch}/libarrow_cdata_jni.so` instead of
`lib/${arch}/libarrow_cdata_jni.so`? Nameing conflict? We don't have distinct
base name such `libarrow_cdata_jni` and `libarrow_dataset_jni`. So I think that
no naming conflict is happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
