jduo commented on code in PR #39221:
URL: https://github.com/apache/arrow/pull/39221#discussion_r1452570972
##########
ci/scripts/java_jni_build.sh:
##########
@@ -56,7 +68,7 @@ cmake \
-DBUILD_TESTING=${ARROW_JAVA_BUILD_TESTS} \
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
-DCMAKE_PREFIX_PATH=${arrow_install_dir} \
- -DCMAKE_INSTALL_LIBDIR=lib \
+ -DCMAKE_ARCH_DIR=${normalized_arch} \
Review Comment:
Sure, I'll fix the name of the ARCH_DIR variable.
Yes the reason is a naming conflict. It's only visible when using JPMS
modules.
It's because we see multiple JPMS modules (where a JPMS module is a JAR with
a module-info.class file) that contain the same subfolder at the root level
(the ${arch} folder). JPMS sees this as a package collision even though the
directory only contains binaries and throws startup exceptions in this scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
