jorisvandenbossche commented on code in PR #359:
URL: https://github.com/apache/arrow-nanoarrow/pull/359#discussion_r1452406065


##########
ci/scripts/coverage.sh:
##########
@@ -137,6 +146,36 @@ function main() {
     show_header "R package coverage summary"
     Rscript -e 'library(covr); print(readRDS("r_coverage.rds"))'
     popd
+
+    # Build + test Python package with cython/gcc coverage options
+    show_header "Build + test Python package"
+    pushd "${SANDBOX_DIR}"
+    TARGET_NANOARROW_PYTHON_DIR="${TARGET_NANOARROW_DIR}/python"
+
+    pushd "${TARGET_NANOARROW_PYTHON_DIR}"
+    python -m pip install -e .
+    NANOARROW_COVERAGE=1 python setup.py build_ext --inplace

Review Comment:
   ```suggestion
       NANOARROW_COVERAGE=1 python -m pip install -e .
   ```
   
   That doesn't work? (`pip install -e .` should essentially under the hood 
already be calling `python setup.py build_ext --inplace`, but then through 
official APIs)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to