paleolimbot commented on code in PR #359:
URL: https://github.com/apache/arrow-nanoarrow/pull/359#discussion_r1452499367


##########
python/setup.py:
##########
@@ -65,6 +66,11 @@ def get_version(pkg_path):
     extra_link_args = []
     extra_define_macros = []
 
+# Setting the CFLAGS environment variable doesn't seem sufficient in all cases 
to add

Review Comment:
   Thanks for the heads up! I'll spend a bit more time debugging to make sure 
I'm not imagining this limitation. I wonder if it's also because I'm setting 
`extra_compile_args` to `[]` and that somehow overrides CFLAGS.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to