adamreeve commented on code in PR #39623:
URL: https://github.com/apache/arrow/pull/39623#discussion_r1454388172
##########
cpp/src/parquet/encryption/internal_file_decryptor.cc:
##########
@@ -168,21 +172,7 @@ std::shared_ptr<Decryptor>
InternalFileDecryptor::GetColumnDataDecryptor(
std::shared_ptr<Decryptor> InternalFileDecryptor::GetColumnDecryptor(
const std::string& column_path, const std::string& column_key_metadata,
const std::string& aad, bool metadata) {
- std::string column_key;
Review Comment:
Would it make sense to at least cache `column_key` though? As mentioned in
the PR description, `key_retriever()->GetKey` might call out to the user's key
management service and could be fairly expensive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
