adamreeve commented on code in PR #39623:
URL: https://github.com/apache/arrow/pull/39623#discussion_r1454403574
##########
cpp/src/parquet/encryption/internal_file_decryptor.cc:
##########
@@ -168,21 +172,7 @@ std::shared_ptr<Decryptor>
InternalFileDecryptor::GetColumnDataDecryptor(
std::shared_ptr<Decryptor> InternalFileDecryptor::GetColumnDecryptor(
const std::string& column_path, const std::string& column_key_metadata,
const std::string& aad, bool metadata) {
- std::string column_key;
Review Comment:
Although if double wrapping is used, it looks like keys will be cached with
`kek_per_kek_id_` in `FileKeyUnwrapper` so maybe the performance impact won't
be too bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
