berkaysynnada commented on PR #8891: URL: https://github.com/apache/arrow-datafusion/pull/8891#issuecomment-1895847463
> This PR: > > Removes RewriteRecursion, > Renames VisitRecursion to TreeNodeRecursion, > Modifies TreeNodeRewriter to incorporate an f_down and f_up methods and use TreeNodeRecursion These changes seem reasonable to me and, since they propose a similar approach to other recursive flows, they make understanding easier. However, I am not sure about this change: > Modifies TreeNode.transform() to accept an f_down and f_up closures and use TreeNodeRecursion. `transform()` is a simple method for traversing the graph with given self-concerned rules, being not interested in the type of traversal. This new version forces awareness of the traversal order, and there is also an implicit convention of traversing first bottom-up, then top-down. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
