peter-toth commented on PR #8891: URL: https://github.com/apache/arrow-datafusion/pull/8891#issuecomment-1895965561
> > I'm not sure I get this part. > > The docstring you have updated for `transform()` states that the order is: > > ``` > 1) f_down(ParentNode) > 2) f_down(ChildNode1) > 3) f_up(ChildNode1) > 4) f_down(ChildNode2) > 5) f_up(ChildNode2) > 6) f_up(ParentNode) > ``` This is correct. This is because the suggested `transform()` does only one traversal. It is exactly the same order how the old and new `TreeNode::rewrite` / `TreeNodeRewriter` worked and works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
