Omega359 commented on code in PR #8862:
URL: https://github.com/apache/arrow-datafusion/pull/8862#discussion_r1456167057


##########
datafusion/expr/src/built_in_function.rs:
##########
@@ -446,7 +450,9 @@ impl BuiltinScalarFunction {
             BuiltinScalarFunction::DatePart => Volatility::Immutable,
             BuiltinScalarFunction::DateTrunc => Volatility::Immutable,
             BuiltinScalarFunction::DateBin => Volatility::Immutable,
+            BuiltinScalarFunction::EndsWith => Volatility::Immutable,
             BuiltinScalarFunction::InitCap => Volatility::Immutable,
+            BuiltinScalarFunction::InStr => Volatility::Immutable,

Review Comment:
   Spark has both position and instr and they are not quite the same signature:
   https://spark.apache.org/docs/latest/api/sql/#position
   https://spark.apache.org/docs/latest/api/sql/#instr



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to