zy-kkk commented on PR #8862:
URL:
https://github.com/apache/arrow-datafusion/pull/8862#issuecomment-1904027369
Hello @alamb, first of all thank you for your review of my PR,
I have used the arrow comparison function for the ends_with function
implementation, and by the way changed starts_with to this,
For the instr function, I added more tests, but for this function, its
implementation in MySQL is: `instr('Helloworld', 'world') = 6`, and for
postgresql, it is, `position(' world' in 'Helloworld') = 6`, which one do you
want me to use, please tell me, currently I still retain the MySQL design
Thanks again for your review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
