vibhatha commented on code in PR #39529:
URL: https://github.com/apache/arrow/pull/39529#discussion_r1457090226
##########
java/vector/src/main/java/org/apache/arrow/vector/complex/impl/PromotableWriter.java:
##########
@@ -301,13 +302,15 @@ public boolean isEmptyStruct() {
return writer.isEmptyStruct();
}
+ @Override
protected FieldWriter getWriter() {
return writer;
}
private FieldWriter promoteToUnion() {
String name = vector.getField().getName();
- TransferPair tp =
vector.getTransferPair(vector.getMinorType().name().toLowerCase(),
vector.getAllocator());
+ TransferPair tp =
vector.getTransferPair(vector.getMinorType().name().toLowerCase(Locale.getDefault()),
+ vector.getAllocator());
Review Comment:
Right! I had doubts between the right one `ROOT` or `getDefault()`, let's
use `ROOT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
