lidavidm commented on code in PR #39529:
URL: https://github.com/apache/arrow/pull/39529#discussion_r1457462946
##########
java/vector/src/test/java/org/apache/arrow/vector/TestLargeListVector.java:
##########
@@ -723,23 +723,23 @@ public void testGetBufferAddress() throws Exception {
Object result = listVector.getObject(0);
ArrayList<Long> resultSet = (ArrayList<Long>) result;
assertEquals(3, resultSet.size());
- assertEquals(new Long(50), resultSet.get(0));
- assertEquals(new Long(100), resultSet.get(1));
- assertEquals(new Long(200), resultSet.get(2));
+ assertEquals(Long.valueOf(50), resultSet.get(0));
+ assertEquals(Long.valueOf(100), resultSet.get(1));
+ assertEquals(Long.valueOf(200), resultSet.get(2));
Review Comment:
No, I think it's fine to use 10L and rely on autoboxing. And since
resultSet.get may return null it's not valid to assume it'll be non-null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
