Omega359 commented on code in PR #8886:
URL: https://github.com/apache/arrow-datafusion/pull/8886#discussion_r1457587640
##########
datafusion/sqllogictest/test_files/timestamps.slt:
##########
@@ -331,6 +331,35 @@ SELECT COUNT(*) FROM ts_data_secs where ts >
to_timestamp_seconds('2020-09-08T12
----
2
+# to_timestamp with formatting
+query I
+SELECT COUNT(*) FROM ts_data_nanos where ts >
to_timestamp('2020-09-08T12:00:00+00:00', '2020-09-08 12/00/00+00:00', '%c',
'%+', '%Y-%m-%d %H/%M/%s%#z')
Review Comment:
#2 is primarily covered in lines 1992 - 2010. I'll update the tests to
include #1 & #3 and #2 using a table vs static string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
