Omega359 commented on PR #8886: URL: https://github.com/apache/arrow-datafusion/pull/8886#issuecomment-1899200364
> Thanks @alamb I would probably stick to PG standard as we declared. The PR implementation is really cool, and we may want to have a separate function for it? like `from_chrono` or something I had a thought for the future to allow for setting the format based on either config or based on dialect. I was thinking that might be best left to after the function refactor (https://github.com/apache/arrow-datafusion/issues/8045) is done then have separate implementations if desired. I just didn't want to write a parser for the PG syntax as it's pretty detailed and just wanted to get something out there. [Someone else noted](https://github.com/apache/arrow-datafusion/issues/5398#issuecomment-1820970911) the complexity of implementing the PG syntax Do you have happen to have such a parser available? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
