zeroshade commented on code in PR #1456:
URL: https://github.com/apache/arrow-adbc/pull/1456#discussion_r1458046880
##########
go/adbc/driver/snowflake/record_reader.go:
##########
@@ -389,7 +386,15 @@ func jsonDataToArrow(ctx context.Context, bldr
*array.RecordBuilder, ld gosnowfl
return nil, err
}
- if tz != time.UTC {
+ snowflakeType, ok :=
bldr.Schema().Field(i).Metadata.GetValue(MetadataKeySnowflakeType)
+ if !ok {
+ return nil, errToAdbcErr(
+ adbc.StatusInvalidData,
+ fmt.Errorf("key %s not found in
metadata for field %s", MetadataKeySnowflakeType, bldr.Schema().Field(i).Name),
+ )
+ }
Review Comment:
Are we guaranteed that `SNOWFLAKE_TYPE` will *always* appear in the
metadata? Should we rely on it rather than falling back to making an inference
if the metadata key isn't there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
