alamb commented on PR #8886: URL: https://github.com/apache/arrow-datafusion/pull/8886#issuecomment-1901137831
Thank you again @Omega359 @comphead and @gruuya > I'll leave the final decision to @alamb although he already approved. My point it would be unexpected to users to have `to_timestamp` behaving differently comparing to PG. I prefer a separate method for `from_chrono` conversions, I agree in an ideal world, `to_timestamp` formatting would behave identically to an existing implementation (e.g. spark or postgres). However, as has been noted this is a non trivial amount of work. I filed https://github.com/apache/arrow-datafusion/issues/8915 to track this item > but if we decide to go with current approach we need to provide more documentation and examples for users in `scalar_functions.md`. Ideally even to have a separate doc page with examples I agree this would be really nice to add All in all I think this functionality is important enough to provide users ways to parse timestamps with alternate formatting, even if the supported format strings aren't the ideal form. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
