comphead opened a new pull request, #8920:
URL: https://github.com/apache/arrow-datafusion/pull/8920
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
Before the PR the Datafusion derives the output datatypes for builtin
functions twice.
Initially set in `BuiltInWindowFunction::return_type` the output datatype
redefined in other places:
- in built in function implementations, like row_number, rank, etc
- on physical planner phase like lag, lead
This PR is to unify output types to be defined in 1 single place and be
transferred through the schema.
Another good benefit of it is other systems that embed DataFusion as an
engine can now use its datatypes by constructing expected schema.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
Datatype definition unified, covered with new tests, some other minor
optimizations
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
