comphead commented on code in PR #8920:
URL: https://github.com/apache/arrow-datafusion/pull/8920#discussion_r1461015772


##########
datafusion/core/src/physical_planner.rs:
##########
@@ -719,14 +720,16 @@ impl DefaultPhysicalPlanner {
                     }
 
                     let logical_input_schema = input.schema();
-                    let physical_input_schema = input_exec.schema();
+                    // Extend the schema to include window expression fields 
as builtin window functions derives its datatype from incoming schema

Review Comment:
   input schema is schema from previous plan node(no window expressions). afaik 
windows expression column being added separately
   
   
https://github.com/apache/arrow-datafusion/blob/0116e2a9b4a3ed4491802e19195769b96b7a971a/datafusion/expr/src/logical_plan/plan.rs#L2045



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to