peter-toth commented on issue #8913: URL: https://github.com/apache/arrow-datafusion/issues/8913#issuecomment-1901997314
@alamb If you don't mind I would suggest a bit different list of tasks as there are API inconsistencies that can be fixed without `transform_with_payload`. 1. For example https://github.com/apache/arrow-datafusion/pull/8891 tries to fix 2 things that don't need a new base API. The 2 questions there is more like if / to what extent we want to: - change`rewrite` / `TreeNodeRewriter` signature / semantics - combine `VisitRecursion` + `RewriteRecursion` into `TreeNodeRecursion` - change `transform` signature / semantics to make the APIs more consistent. 2. For `transform_with_payload` I already have a PR: https://github.com/apache/arrow-datafusion/pull/8664, it is not exactly the above "ideal" form of the API, but already shows its capabilities. The question here is more like if it make sense / when can we move towards that base API. cc @ozankabak 3. For `tranform` / `rewrite` early termination I want to open a new PR. 4. For the `Transformed` enum issue I also have a PR: https://github.com/apache/arrow-datafusion/pull/8835. If the decision is to remove the enum then it is independent of other PRs as the conflict it causes is minimal and straightforward to fix. But if we want to keep and fix it then then it will be huge change and only make sense to do after all the above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
