peter-toth commented on issue #8913: URL: https://github.com/apache/arrow-datafusion/issues/8913#issuecomment-1902068159
> All in all, the composability/reusability we will get via https://github.com/apache/arrow-datafusion/pull/8817 is really critical to certain use cases and upcoming contributions. Let's get that in and then let's discuss refining the transform signatures and fixing inefficiencies pertaining to Recursion enums. I actually like some of your core ideas but I get the sense that you may not have the full picture on this part of the code, its current/possible downstream uses, possible future extensions and subtle logical dependencies. I can't argue with that since I don't see your downstream code, but I'm looking forward to see a usecase where `PlanContext` or `ExprContext ` this is actually needed. > In any case, I agree that parts of https://github.com/apache/arrow-datafusion/pull/8891 would be a good next step to iterate on and improve after https://github.com/apache/arrow-datafusion/pull/8817 merges. FYI, I hope to finish https://github.com/apache/arrow-datafusion/pull/8817 in a few days so that I can help with the rest of the work. Thanks for the update! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
