Re: [PR] Add syntax highlight to datafusion-cli [arrow-datafusion]

Sat, 20 Jan 2024 13:40:48 -0800 


trungda commented on PR #8918:
URL: 
https://github.com/apache/arrow-datafusion/pull/8918#issuecomment-1902271454

   > <img alt="image" width="87" 
src="https://private-user-images.githubusercontent.com/10247224/298308538-10c56c78-4277-4b71-8612-6564638bea38.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU3ODY3MDIsIm5iZiI6MTcwNTc4NjQwMiwicGF0aCI6Ii8xMDI0NzIyNC8yOTgzMDg1MzgtMTBjNTZjNzgtNDI3Ny00YjcxLTg2MTItNjU2NDYzOGJlYTM4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIwVDIxMzMyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM1ZWZmZDA0MzlkMjBmNWYzMDNhZThmMWI3YWQwODExZDIzMGI1NDUzYmQ0YWQ0MjlkYzhhOTFiNjJjNGU3YjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ZQ42izYYG11pZ4KSJSX8R2jwuXeTx4ElDrn0M14uTP4";>
   
   Thanks for the feedback @comphead . What is your terminal setup? I am not 
able to repro yet. The current approach is to take the whole input string and 
tokenize the input as a whole, the arrow keys shouldn't matter. 
   
   ![Screenshot from 2024-01-20 
13-38-32](https://github.com/apache/arrow-datafusion/assets/2529107/64a30aa6-df01-44bd-adf9-e6238350c30d)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to