trungda commented on PR #8918: URL: https://github.com/apache/arrow-datafusion/pull/8918#issuecomment-1903363187
Thanks @alamb ! I've updated the license + changed the color to be lighter as suggested. > That would be great -- thank you @trungda (this is somewhat related); https://github.com/sqlparser-rs/sqlparser-rs/pull/1094 This is great! I'll look into that. It'd be easier if somehow we know the position in the original string where the tokernization fails just so we can just copy from that position to the highlighted string. > Another feature that would be neat would be a CLI flag to enable/disable the highlighting so people who find the color scheme not to their liking could turn it off Sounds great! Let me look into that after this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
