Weijun-H commented on code in PR #8902:
URL: https://github.com/apache/arrow-datafusion/pull/8902#discussion_r1460707671
##########
datafusion/expr/src/built_in_function.rs:
##########
@@ -963,15 +967,20 @@ impl BuiltinScalarFunction {
BuiltinScalarFunction::ArrayPosition => {
Signature::variadic_any(self.volatility())
}
- BuiltinScalarFunction::ArrayPositions => Signature::any(2,
self.volatility()),
- BuiltinScalarFunction::ArrayPrepend => Signature {
- type_signature: ElementAndArray,
- volatility: self.volatility(),
- },
+ BuiltinScalarFunction::ArrayPositions => {
+ Signature::array_and_element(self.volatility())
+ }
+ BuiltinScalarFunction::ArrayPrepend => {
+ Signature::element_and_array(self.volatility())
+ }
BuiltinScalarFunction::ArrayRepeat => Signature::any(2,
self.volatility()),
Review Comment:
Although the functions including `array_repeat`, `array_union`,
`array_intersect`, and `array_except` are also two-argument,
`Signature::array_and_element` could not handle `NULL` well for them. The
following PR could continue to work on this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
