jayzhan211 commented on code in PR #8902:
URL: https://github.com/apache/arrow-datafusion/pull/8902#discussion_r1461325029


##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -311,6 +329,8 @@ fn coerced_from<'a>(
         Utf8 | LargeUtf8 => Some(type_into.clone()),
         Null if can_cast_types(type_from, type_into) => 
Some(type_into.clone()),
 
+        List(_) if matches!(type_from, FixedSizeList(_, _)) => 
Some(type_into.clone()),

Review Comment:
   Will it be easier if we run Fixedsizelist to List like 
`coerce_arguments_for_fun` before this type coercion?



##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -311,6 +329,8 @@ fn coerced_from<'a>(
         Utf8 | LargeUtf8 => Some(type_into.clone()),
         Null if can_cast_types(type_from, type_into) => 
Some(type_into.clone()),
 
+        List(_) if matches!(type_from, FixedSizeList(_, _)) => 
Some(type_into.clone()),

Review Comment:
   Will it be easier if we run Fixedsizelist to List like 
`coerce_arguments_for_fun` before this signature type coercion?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to