joellubi commented on code in PR #1456:
URL: https://github.com/apache/arrow-adbc/pull/1456#discussion_r1460711968
##########
go/adbc/driver/snowflake/statement.go:
##########
@@ -406,6 +481,10 @@ func convToSlice[T, O constraints.Integer |
constraints.Float](arr arrow.Array,
return gosnowflake.Array(&out)
}
+// This is now unused after the previous INSERT-bind bulk ingestion was
removed.
+// TODO(joellubi): We could use this again when stmt.Prepare() is implemented.
+//
+//nolint:golint,unused
func getQueryArg(arr arrow.Array) interface{} {
Review Comment:
Sure thing, I cleaned this up
##########
go/adbc/driver/snowflake/statement.go:
##########
@@ -335,18 +405,20 @@ func (st *statement) initIngest(ctx context.Context)
(string, error) {
createQuery := createBldr.String()
_, err := st.cnxn.cn.ExecContext(ctx, createQuery, nil)
if err != nil {
- return "", errToAdbcErr(adbc.StatusInternal, err)
+ return errToAdbcErr(adbc.StatusInternal, err)
}
}
- return insertBldr.String(), nil
+ return nil
}
+//nolint:golint,unused
type nativeArrowArr[T string | []byte] interface {
arrow.Array
Value(int) T
}
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
