alamb opened a new issue, #8932: URL: https://github.com/apache/arrow-datafusion/issues/8932
### Describe the bug As described on https://github.com/apache/arrow-datafusion/pull/8908, the `PartialOrd` implementation of `Expr` is based on comparing the hash values of the two nodes This is problematic because there can be different orderings for the same expression: 1. Different releases of `ahash` 2. Different platforms (as we saw with https://github.com/apache/arrow-datafusion/pull/8908 / [35.0.0 release verification](https://lists.apache.org/thread/onbs8l0w5s7693fchpyvwwgh61gf1jf8) Here is the current implementation https://github.com/apache/arrow-datafusion/blob/b7e13a0af711477ad41450566c14430089edd3f2/datafusion/expr/src/expr.rs#L850-L862 ### To Reproduce _No response_ ### Expected behavior I expect that PartialOrd of `Expr` will not change -- we probably have to implement a real `PartialOrd` implementation that compares each field (or maybe derive) ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
