alamb commented on issue #8932: URL: https://github.com/apache/arrow-datafusion/issues/8932#issuecomment-1902613083
@tustvold notes on https://github.com/apache/arrow-datafusion/pull/8908#discussion_r1460841842: > Edit: as suspected it looks like PartialEq is being derived using a proc macro, and is therefore inconsistent with this implementation of PartialOrd - https://github.com/apache/arrow-datafusion/blob/main/datafusion/expr/src/expr.rs#L87. In particular PartialOrd could claim things to be equal due to a hash collision, when PartialEq would indicate they are not So my conclusion is that this is a latent bug waiting to happen (that will be very hard to track down if/when it does strike) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
