korowa commented on code in PR #8020:
URL: https://github.com/apache/arrow-datafusion/pull/8020#discussion_r1461006198
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -665,6 +668,8 @@ impl ExecutionPlan for HashJoinExec {
reservation,
state: HashJoinStreamState::WaitBuildSide,
build_side: BuildSide::Initial(BuildSideInitialState { left_fut }),
+ batch_size,
Review Comment:
I suppose `batch_size` is the best fit out of all settings DF has at this
moment -- there is no such setting (AFAIK) as `batch_size_bytes` / anything
like adaptive batching based on memory size, so I suppose this logic to be more
or less aligned with other operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
