korowa commented on code in PR #8020:
URL: https://github.com/apache/arrow-datafusion/pull/8020#discussion_r1461006660
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -1023,11 +1048,9 @@ pub fn build_equal_condition_join_indices<T:
JoinHashMapType>(
random_state: &RandomState,
null_equals_null: bool,
hashes_buffer: &mut Vec<u64>,
- filter: Option<&JoinFilter>,
- build_side: JoinSide,
- deleted_offset: Option<usize>,
- fifo_hashmap: bool,
-) -> Result<(UInt64Array, UInt32Array)> {
+ limit: usize,
+ offset: JoinHashMapOffset,
+) -> Result<(UInt64Array, UInt32Array, Option<JoinHashMapOffset>)> {
let keys_values = probe_on
Review Comment:
Fixed, now hashes calculated in `fetch_probe_batch`, once per multiple
possible iterations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
