jackwener commented on code in PR #8928:
URL: https://github.com/apache/arrow-datafusion/pull/8928#discussion_r1461298706
##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -655,6 +658,20 @@ impl TreeNodeVisitor for ExprIdentifierVisitor<'_> {
}
}
+/// Check if the expression is short-circuit expression
+fn is_short_circuit_expression(expr: &Expr) -> bool {
Review Comment:
Additionally, we'd better enumerate all expressions here(But I'm not sure).
This means we would need to consider whether it's short-circuiting when
adding a new expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
